fix(memory): strip extra properties when loading entities from JSONL#3167
Closed
cardmagic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
fix(memory): strip extra properties when loading entities from JSONL#3167cardmagic wants to merge 1 commit intomodelcontextprotocol:mainfrom
cardmagic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
When loading entities and relations from JSONL files, the parsed JSON objects included extra properties like `type` (used for discriminating entity vs relation) and any other custom fields. These extra properties leaked into the Entity/Relation objects, causing MCP schema validation errors (-32602 Invalid params) when outputSchema validation is enabled. The fix explicitly extracts only the schema-defined properties (name, entityType, observations for entities; from, to, relationType for relations) instead of casting the entire parsed object. Fixes modelcontextprotocol#3144
Author
|
Closing as duplicate - this is already addressed by #3161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When loading entities and relations from JSONL files, the parsed JSON objects included extra properties like
type(used for discriminating entity vs relation) and any other custom fields that may have been manually added or present in legacy data. These extra properties leaked into the Entity/Relation objects, causing MCP schema validation errors (-32602 Invalid params) when outputSchema validation is enabled.The fix: Explicitly extract only the schema-defined properties (name, entityType, observations for entities; from, to, relationType for relations) instead of casting the entire parsed JSON object.
Test plan
Fixes #3144